Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FoV Rotation control #211

Open
simontorres opened this issue Dec 11, 2024 · 6 comments
Open

FoV Rotation control #211

simontorres opened this issue Dec 11, 2024 · 6 comments

Comments

@simontorres
Copy link
Contributor

Issue #6 mentions a setRotation method but I can't find it. If it was removed would you point me to the reasoning behind it?.

Thanks!.

Note

If you zoom out a lot and move the field around, the fov comes back rotated. It would be nice to have control over the rotation of the field , either to return it to no rotation or to rotate it on purpose.

@tboch
Copy link
Collaborator

tboch commented Dec 12, 2024

pinging @bmatthieu3 : it seems that setRotationis no longer available as a method in latest beta. Can you revive this?

@tboch
Copy link
Collaborator

tboch commented Dec 16, 2024

@simontorres : the method has been renamed setViewCenter2NorthPoleAngle , but we will bring back the farmer setRotationmethod name.

@simontorres
Copy link
Contributor Author

Thanks @tboch !

@bmatthieu3
Copy link
Collaborator

I agree the function label is not that great. Should we authorize setRotation back (without removing setViewCenter2NorthPoleAngle) or define a new label. I think about: setNorthOrientation(angle)

@tboch
Copy link
Collaborator

tboch commented Jan 16, 2025

setRotationsounds fine to me. If you want a better name, I can think of rotateTo.
In any case, I'd like setRotationto stay there as an alias at least.

@simontorres
Copy link
Contributor Author

I like setRotation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants