Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature files in test/tests/features are being included for every cekit test #66

Closed
jmtd opened this issue Apr 3, 2024 · 0 comments · Fixed by #67
Closed

feature files in test/tests/features are being included for every cekit test #66

jmtd opened this issue Apr 3, 2024 · 0 comments · Fixed by #67

Comments

@jmtd
Copy link
Collaborator

jmtd commented Apr 3, 2024

cekit test works by cloning this repository to target/test, and then copying on top the relevant behave files from the image being tested. It then invokes behave.

behave operates from target/test and includes any *.feature file it can find: so, every cekit test run for any image since merging #61 is picking up those feature files.

They may or may not be run (depending on what tags are defined for the image), but they cause cekit tests to fail, which expect a certain number of scenarios/features/steps to be defined.

jmtd added a commit to jmtd/behave-test-steps that referenced this issue Apr 3, 2024
To prevent these feature files leaking out to all `cekit test` users,
rename them with a ".disabled" suffix. They will still be cloned into
every cekit test run, but will be ignored by behave.

For our GHA tests, re-enable them by renaming to remove the suffix.

Fixes cekit#66.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd closed this as completed in #67 Apr 3, 2024
jmtd added a commit that referenced this issue Apr 3, 2024
Disable our feature files by default (#66)
jmtd added a commit to jmtd/behave-test-steps that referenced this issue Nov 21, 2024
To prevent these feature files leaking out to all `cekit test` users,
rename them with a ".disabled" suffix. They will still be cloned into
every cekit test run, but will be ignored by behave.

For our GHA tests, re-enable them by renaming to remove the suffix.

Fixes cekit#66.

Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant