container.execute: fix when exec_start completes fast #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p.join will return None in two situations: when the timeout is reached, and if the process has completed already. Adjust the check so that we throw an exception in the former case but not the latter. Signed-off-by: Jonathan Dowland <[email protected]>
|
Confirmation that this fixed wildfly: wildfly/wildfly-s2i#464 |
jmtd
added a commit
to jmtd/behave-test-steps
that referenced
this pull request
Mar 21, 2024
See also PR cekit#60. Signed-off-by: Jonathan Dowland <[email protected]>
|
@jmtd If this confirms the issue, are you merging it ? |
|
@rnc I seem to lack permission to merge it myself. I was hoping to learn whether this also addressed cekit/cekit#903 , but I think fixing wildfly's test runs is probably sufficient to merge it. |
|
@jmtd I've modified your permissions. |
rnc
pushed a commit
that referenced
this pull request
Mar 23, 2024
* In-source behave tests from OpenJDK for regression suite The GHA job up until now relied upon running the externally-defined behave tests for the OpenJDK container images (runtime variant). The external test suite is primarily designed to cover the OpenJDK image, and not to provide coverage of all of the behave-test-steps. Rework the job to operate on a local copy of these behave tests. (Also do a bit of spring-cleaning) Future work can adjust the feature files to provide better coverage for the steps defined in this repository. Signed-off-by: Jonathan Dowland <[email protected]> * Test to exercise 'File . should contain' See also PR #60. Signed-off-by: Jonathan Dowland <[email protected]> --------- Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
added a commit
to jmtd/behave-test-steps
that referenced
this pull request
Nov 21, 2024
p.join will return None in two situations: when the timeout is reached, and if the process has completed already. Adjust the check so that we throw an exception in the former case but not the latter. Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
added a commit
to jmtd/behave-test-steps
that referenced
this pull request
Nov 21, 2024
* In-source behave tests from OpenJDK for regression suite The GHA job up until now relied upon running the externally-defined behave tests for the OpenJDK container images (runtime variant). The external test suite is primarily designed to cover the OpenJDK image, and not to provide coverage of all of the behave-test-steps. Rework the job to operate on a local copy of these behave tests. (Also do a bit of spring-cleaning) Future work can adjust the feature files to provide better coverage for the steps defined in this repository. Signed-off-by: Jonathan Dowland <[email protected]> * Test to exercise 'File . should contain' See also PR cekit#60. Signed-off-by: Jonathan Dowland <[email protected]> --------- Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p.join will return None in two situations: when the timeout is reached, and if the process has completed already.
Adjust the check so that we throw an exception in the former case but not the latter.
This hopefully fixes a reported error in running the test suite for https://github.com/wildfly/wildfly-s2i/actions/runs/8345796441/job/22876447353#step:16:2666
For this wishing to test this: at the moment https://github.com/jmtd/behave-test-steps branch
v1has this patch.