Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure e2e test uses "test" chain ID #4074

Closed
rootulp opened this issue Dec 2, 2024 · 3 comments · Fixed by #4090
Closed

Ensure e2e test uses "test" chain ID #4074

rootulp opened this issue Dec 2, 2024 · 3 comments · Fixed by #4090
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 2, 2024

Context

#4065

Motivation

In a call today, we weren't sure if the end-to-end test uses the "test" chain ID

Proposal

Ensure that the end-to-end test for upgrading to v3 uses the "test" chain ID

@rootulp rootulp self-assigned this Dec 2, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 6, 2024

There are 4 e2e tests:

  1. MinorVersionCompatibility
  2. MajorUpgradeToV2
  3. MajorUpgradeToV3
  4. E2ESimple

We only care about MajorUpgradeToV3 using the test chain ID.

One thing worth noting: each block that the knuu network produces only contains 1 tx so I expect it will take a while for txsim to randomly submit a MsgSignalUpgrade 3 and then a subsequent MsgTryUpgrade

@evan-forbes
Copy link
Member

knuu network produces only contains 1 tx

do you know why this is? is it just because we're running one txsim?

@rootulp
Copy link
Collaborator Author

rootulp commented Dec 7, 2024

Not sure. I expected txsim to submit more than one tx per block but I could be wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants