Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract the mebibyte constant and export it #4211

Open
rach-id opened this issue Jan 13, 2025 · 1 comment
Open

extract the mebibyte constant and export it #4211

rach-id opened this issue Jan 13, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented Jan 13, 2025 

          a super tiny nit for a follow up issue would be to extract the `mebibyte` constant and export it somewhere. We have a lot of redefinitions of it, so it would be good to use the same one to avoid any mistakes

Originally posted by @rach-id in #4205 (comment)
@rach-id rach-id added the good first issue Good for newcomers label Jan 13, 2025
@ZwangaMukwevho ZwangaMukwevho mentioned this issue Jan 14, 2025
Open
@rootulp
Copy link
Collaborator

rootulp commented Jan 16, 2025

Where should we export it from? It seems like it shouldn't be public API of any of our packages so IMO fine to redefine it as an unexported const in all the packages it is used in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @rach-id