Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share: benchmark Read/WriteEDS #1106

Closed
Tracked by #1099
Wondertan opened this issue Sep 15, 2022 · 1 comment · Fixed by #1197
Closed
Tracked by #1099

share: benchmark Read/WriteEDS #1106

Wondertan opened this issue Sep 15, 2022 · 1 comment · Fixed by #1197
Assignees
@distractedm1nd
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Sep 15, 2022 •
edited
Loading

Introduced #1104 and #1105 are allocations and CPU-intensive serialization functions. We should know how they perform and always have a starting point on where to improve further.
@Wondertan Wondertan mentioned this issue Sep 15, 2022
Closed
45 tasks
@Wondertan Wondertan added the area:shares Shares and samples label Sep 15, 2022
@Wondertan Wondertan moved this to TODO in Celestia Node Sep 16, 2022
@Wondertan Wondertan mentioned this issue Oct 4, 2022
Merged
@Wondertan
Copy link
Member Author

Wondertan commented Oct 4, 2022 •
edited
Loading

A draft of optimizations tbd for WriteEDS:

  • Use sha256-simd
  • Use buffer pool for CAR allocations
  • Avoid copying the EDS
    • Write shares/samples at the moment of iterating

@distractedm1nd distractedm1nd mentioned this issue Oct 4, 2022
Merged
@distractedm1nd distractedm1nd moved this from TODO to In Review in Celestia Node Oct 10, 2022
@distractedm1nd distractedm1nd self-assigned this Oct 10, 2022
Repository owner moved this from In Review to Done in Celestia Node Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(blocksync): Benchmarks for ReadEDS and WriteEDS distractedm1nd/celestia-node
2 participants
@distractedm1nd @Wondertan