Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share/ipld: Remove duplicated namespace appended by NMTWrapper #1239

Closed
Tracked by #1099
renaynay opened this issue Oct 17, 2022 · 1 comment
Closed
Tracked by #1099

share/ipld: Remove duplicated namespace appended by NMTWrapper #1239

renaynay opened this issue Oct 17, 2022 · 1 comment
Assignees
Labels
area:ipld IPLD plugin area:shares Shares and samples

Comments

@renaynay
Copy link
Member

renaynay commented Oct 17, 2022

Context

The NMTWrapper in celestia-core prepends to share (leaf nodes) an additional namespace, which is just a copy of real namespaces or the constant parity namespace.

Goal

Optimize data storage and network by removing this additional prepended namespace and automatically prepend it where needed.

Refs

celestiaorg/nmt#55 (comment)

@renaynay renaynay added area:shares Shares and samples area:ipld IPLD plugin labels Oct 17, 2022
@renaynay renaynay moved this to TODO in Celestia Node Oct 17, 2022
@Wondertan Wondertan changed the title share/ipld: Remove dependency on duplicate prepended namespaceID share/ipld: Remove duplicated namespace appended by NMTWrapper Oct 24, 2022
@Wondertan Wondertan removed their assignment Oct 24, 2022
@Wondertan
Copy link
Member

Unfortunately, we cannot implement this(in a clean way without introducing additional complexity).

If we want to cut the additional namespace added by NMTWrapper, then we should add it back once we receive it from the network so that we can properly verify the integrity. Doing this requires namespaceHasher to know from which quadrant the share data is coming, which is not possible

@Wondertan Wondertan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2022
Repository owner moved this from TODO to Done in Celestia Node Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ipld IPLD plugin area:shares Shares and samples
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants