Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header/core: Put Blocks into the eds.Store in Listener #1423

Closed
Tracked by #1099
Wondertan opened this issue Dec 1, 2022 · 1 comment
Closed
Tracked by #1099

header/core: Put Blocks into the eds.Store in Listener #1423

Wondertan opened this issue Dec 1, 2022 · 1 comment
Assignees
@renaynay
Labels
area:block Raw blocks and erasure coded blocks area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Dec 1, 2022 •
edited
Loading

Context

Right now, the Listener stores the block data into ipfs.Blockservice during ExtendedHeader and EDS construction. As per #1099, we are now migrating to new storage for blocks - eds.Store and Listener should store the EDS/Block there.

This will likely require changes to the header.MakeExtendedHeader and likely simplify it by removing dependency on ipfs.Blockservice
@Wondertan Wondertan mentioned this issue Dec 1, 2022
Closed
45 tasks
@Wondertan Wondertan changed the title core: Put Blocks into the eds.Store in Listener header/core: Put Blocks into the eds.Store in Listener Dec 1, 2022
@Wondertan Wondertan moved this to TODO in Celestia Node Dec 1, 2022
@Wondertan Wondertan mentioned this issue Dec 1, 2022
Closed
@renaynay renaynay added area:shares Shares and samples area:block Raw blocks and erasure coded blocks and removed needs:triage labels Dec 5, 2022
@renaynay renaynay mentioned this issue Jan 5, 2023
Closed
@renaynay renaynay mentioned this issue Jan 23, 2023
Merged
renaynay added a commit that referenced this issue Jan 24, 2023
@renaynay
refactor(header): Extract CoreExchange and CoreListener out of th…
0eacfc0 
…e header root package (#1627)

This PR is a blocker to #1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
distractedm1nd pushed a commit to distractedm1nd/celestia-node that referenced this issue Jan 26, 2023
@renaynay @distractedm1nd
refactor(header): Extract CoreExchange and CoreListener out of th…
e3f43bf 
…e header root package (celestiaorg#1627)

This PR is a blocker to celestiaorg#1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
walldiss pushed a commit to walldiss/celestia-node that referenced this issue Jan 26, 2023
@renaynay @walldiss
refactor(header): Extract CoreExchange and CoreListener out of th…
e1ebf7b 
…e header root package (celestiaorg#1627)

This PR is a blocker to celestiaorg#1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
renaynay added a commit to renaynay/celestia-node that referenced this issue Jan 31, 2023
@renaynay
refactor(header): Extract CoreExchange and CoreListener out of th…
bf704f4 
…e header root package (celestiaorg#1627)

This PR is a blocker to celestiaorg#1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
renaynay added a commit that referenced this issue Feb 1, 2023
@renaynay
refactor(header): Extract CoreExchange and CoreListener out of th…
74bc639 
…e header root package (#1627)

This PR is a blocker to #1423

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
@renaynay
Copy link
Member

renaynay commented Mar 6, 2023

Completed as part of ShrEx implementation

@renaynay renaynay closed this as completed Mar 6, 2023
@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renaynay renaynay

Labels
area:block Raw blocks and erasure coded blocks area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(header/core): Put eds in eds.Store in listener renaynay/celestia-node
2 participants
@Wondertan @renaynay