-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
header/core: move Listener
and Exchange
out to the root core
pkg
#1424
Labels
area:header
Extended header
Comments
45 tasks
core
pkgListener
out to the root core
pkg
Listener
out to the root core
pkgListener
and Exchange
out to the root core
pkg
This will likely be done by #1304 |
You want me to do it? Or you're going to refactor after #1304? |
@tzdybal, I was thinking about this issue from a different perspective but realized that your PR touches on it as well and moves those components anyway, so would be nice to move them to the root |
Already done by #1627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The listener works with block data and constructs EDSes, but it is located under the
header
pkg, which should not depend onshare
anyhow. Further, theListener
will depend oneds.Store
(#1423) which may introduce a dep cycle.The same is true for the
header/core.Exchange
The text was updated successfully, but these errors were encountered: