Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header/core: move Listener and Exchange out to the root core pkg #1424

Closed
Tracked by #1099
Wondertan opened this issue Dec 1, 2022 · 4 comments
Closed
Tracked by #1099

header/core: move Listener and Exchange out to the root core pkg #1424

Wondertan opened this issue Dec 1, 2022 · 4 comments
Labels
area:header Extended header

Comments

@Wondertan
Copy link
Member

Wondertan commented Dec 1, 2022

The listener works with block data and constructs EDSes, but it is located under the header pkg, which should not depend on share anyhow. Further, the Listener will depend on eds.Store(#1423) which may introduce a dep cycle.

The same is true for the header/core.Exchange

@Wondertan Wondertan moved this to TODO in Celestia Node Dec 1, 2022
@Wondertan Wondertan changed the title header/core: move Listener out to the root core pkg header/core: move Listener out to the root core pkg Dec 1, 2022
@Wondertan Wondertan changed the title header/core: move Listener out to the root core pkg header/core: move Listener and Exchange out to the root core pkg Dec 1, 2022
@Wondertan
Copy link
Member Author

This will likely be done by #1304

@tzdybal
Copy link
Member

tzdybal commented Dec 3, 2022

You want me to do it? Or you're going to refactor after #1304?

@Wondertan
Copy link
Member Author

@tzdybal, I was thinking about this issue from a different perspective but realized that your PR touches on it as well and moves those components anyway, so would be nice to move them to the root core pkg

@renaynay renaynay added area:header Extended header and removed needs:triage labels Dec 19, 2022
@renaynay
Copy link
Member

renaynay commented Mar 6, 2023

Already done by #1627

@renaynay renaynay closed this as completed Mar 6, 2023
@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants