Consider renaming namespace ID to namespace #206
Labels
Comments
rootulp
added
documentation
5 tasks
|
A relevant comment #209 (comment) |
5 tasks
staheri14
added a commit
that referenced
this issue
Jun 28, 2023
## Overview Closes #205 Additionally, in line with [this](#206), to ensure consistency with how **namespace ID** and **namespace** (i.e., a combination of namespace ID and version) are utilized in the core-app, I have replaced all instances of words that refer to or imply **namespace ID** with the more accurate term "**namespace**". ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
5 tasks
5 tasks
|
It would be really nice if we will rename a json representation too, bc in celestia-node we've already had a request to make pb and json definitions consistent |
5 tasks
|
I am unassigning myself from this issue due to other ongoing high-priority big block issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
This library is used in celestia-app. After celestia-app/adr-014 and celestia-app/adr-015 were introduced, the namespaced data that gets pushed to an NMT consists of:
namespace version (1 byte) | namespace ID (28 bytes) = namespace (29 bytes).Problem
It is a bit confusing that this repo refers to them as namespace IDs when celestia-app refers to them as namespaces.
Proposal
Rename namespace ID to namespace in this repo
The text was updated successfully, but these errors were encountered: