-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removes the usage of the merkletree package #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 6 6
Lines 464 464
=======================================
Hits 447 447
Misses 11 11
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this LGTM after we remove the first line from
Lines 98 to 99 in e8ad2aa
This implementation (currently) uses NebulousLabs' [merkletree][NebulousLabs'] implementation | |
and was heavily inspired by the initial implementation in the celestiaorg [prototype]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼 Nice!
Agree on this: #126 (review)
Sure, good point, please see the revised version in f9f65fa. |
Overview
Inline with #125.
For more context, please see the following comment.
Checklist