Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set <check_update>true</check_update> for the AppImage #1413

Closed
davidhedlund opened this issue Nov 10, 2024 · 2 comments
Closed

Only set <check_update>true</check_update> for the AppImage #1413

davidhedlund opened this issue Nov 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@davidhedlund
Copy link

davidhedlund commented Nov 10, 2024

Current Behavior

Both the flatpak package and the appimage generates
<check_update>true</check_update>

Expected Behavior

As pointed out here:
This line

ConfigValue<bool> check_update{true};
should have a macro setting the value to true #if LINUX && !APPIMAGE

@davidhedlund davidhedlund added the bug Something isn't working label Nov 10, 2024
@Exzap Exzap closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2024
@davidhedlund davidhedlund changed the title Appimage: Change <check_update>true</check_update> to false Only set <check_update>true</check_update> for the AppImage Nov 10, 2024
@davidhedlund
Copy link
Author

davidhedlund commented Nov 10, 2024

@Exzap Please re-read this issue. It's entirely different now. I just re-wrote it to avoid spamming the tracker.

@davidhedlund
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants