Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package and other warnings/errors #135

Merged
merged 7 commits into from
Jan 12, 2022
Merged

Fix package and other warnings/errors #135

merged 7 commits into from
Jan 12, 2022

Conversation

aidan-starke
Copy link
Contributor

Closes #133

@vercel
Copy link

vercel bot commented Jan 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cennznet/litho/EkMZtLGJDMHgcibUC4HXK7t3SpZX
✅ Preview: https://litho-git-fix-133-cennznet.vercel.app

@aidan-starke
Copy link
Contributor Author

@PolkaDot packages are a part of @cennznet/api.. there is one remaining warning:

The following conflicting packages were found: 5.9.2 <unknown> 5.9.2 <unknown>

Which I'm not sure how to deal with

@ken-futureverse
Copy link
Collaborator

👀 looking now @aidan-starke

@ken-futureverse
Copy link
Collaborator

@aidan-starke this change e6e22c8 will remove the ability to link the asset to IPFS when in single page view. I'd suggest introduce a new prop linkToIPFS with default as false to the NFTRenderer and set that prop to true for the single view, which is in [serialNumber].tsx:536.

Re 5.9.2 <unknown> 5.9.2 <unknown> warning, nuking the node_modules seems to do the trick so all good there.

Everything else LGTM! 👍

@aidan-starke
Copy link
Contributor Author

@ken-centrality on single page view there is a link below the image 'View on IPFS' which is a litho.mypinata.cloud/ipfs link and I found that to load faster than the ipfs.io link

@ken-futureverse
Copy link
Collaborator

oh true, in that case can we simply wrap the the a tag around <NFT... component that link to the same one as View on IPFS, no need to create any additional props then!?

@vercel vercel bot temporarily deployed to Preview January 12, 2022 02:29 Inactive
@aidan-starke aidan-starke merged commit ae6e46b into main Jan 12, 2022
@aidan-starke aidan-starke deleted the fix/133 branch January 12, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warning about multiple @polkadot/util versions
2 participants