From ed82d3e0e1f4e9587b3e47ef1289a3d83e72ab09 Mon Sep 17 00:00:00 2001 From: agix Date: Fri, 13 Jan 2023 15:48:48 +0100 Subject: [PATCH 1/2] Stops removing outcome field --- pipeline/metadata/schema.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pipeline/metadata/schema.py b/pipeline/metadata/schema.py index 06eaf4b1..08fd7d2e 100644 --- a/pipeline/metadata/schema.py +++ b/pipeline/metadata/schema.py @@ -407,7 +407,6 @@ def dict_to_gcs_dict_hyperquack( measurement_dict.pop('domain_category') measurement_dict.pop('is_known_blockpage') measurement_dict.pop('page_signature') - measurement_dict.pop('outcome') measurement_dict.pop('received_tls_cert_matches_domain') return measurement_dict From 9d4dcd54ccc58b86c12c4c453e1c30e2ccbe75fd Mon Sep 17 00:00:00 2001 From: agix Date: Fri, 13 Jan 2023 15:56:07 +0100 Subject: [PATCH 2/2] Added outcome field to test_hyperquack_flatten_matches_gcs_dict --- pipeline/metadata/test_schema.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pipeline/metadata/test_schema.py b/pipeline/metadata/test_schema.py index 82bd8966..df8b7bd4 100644 --- a/pipeline/metadata/test_schema.py +++ b/pipeline/metadata/test_schema.py @@ -289,7 +289,8 @@ def test_hyperquack_flatten_matches_gcs_dict(self) -> None: 'controls_failed': False, 'stateful_block': False, 'measurement_id': '81e2a76dafe04131bc38fc6ec7bbddca', - 'source': 'CP_Quack-https-2020-11-06-15-15-31' + 'source': 'CP_Quack-https-2020-11-06-15-15-31', + 'outcome': 'content/status_mismatch:302' } # yapf: disable gcs_dict = schema.dict_to_gcs_dict_hyperquack(schema.flatten_to_dict(row))