MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected #1512

Evan-Adam · 2024-07-09T14:41:39Z

Description

fix a file descriptor leak in gorgone when a poller disconnect from zmq socket.

Fixes #3775

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

How this pull request can be tested ?

See robot test.
gorgone should not increase it's file descriptor over time.

Checklist

I have followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have made corresponding changes to the documentation.
I have rebased my development branch on the base branch (master, maintenance).

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

TODO : we need to change the gha to launch this test only on develop, and if possible execute it nighty Refs:MON-48766

Now when a tcp port can't be bind there is an error (robot range start at 0) Refs:MON-37990

MON-48766

coderabbitai · 2024-07-09T14:41:45Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MON-48766

Refs:MON-48766

kduret

ok for docker changes

…rs-leak-in-gorgone-that-occur-when-pollers-are-disconnected

Refs:MON-48766

…r-when-pollers-are-disconnected (#1512) fix(gorgone): fd leak TODO : we need to change the gha to launch this test only on develop, and if possible execute it nighty Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

…isconnected (#1512) Refs:MON-143753 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

…isconnected (#1512) Refs:MON-143754 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

…isconnected (#1512) (#1621) Refs:MON-143753 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

…isconnected (#1512) (#1622) Refs:MON-143754 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

garnier-quentin and others added 10 commits July 9, 2024 08:55

fix(gorgone): fd leak

9092427

fix(gorgone): fd leak

fc8b8fe

Update centreon-gorgone/gorgone/class/clientzmq.pm

afec616

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

better pull connection reconnection

524d38b

better pull reconnection

a21e424

better pull reconnection

4d9a453

test(Gorgone): Test gorgone don't leak file descriptor

19489eb

TODO : we need to change the gha to launch this test only on develop, and if possible execute it nighty Refs:MON-48766

wip(test gorgone): fix tests

b16dc45

tests(gorgone): Add test for Gorgone statistics module

89efd8f

Now when a tcp port can't be bind there is an error (robot range start at 0) Refs:MON-37990

fix(gorgone-tests): use correct datatype in function call

cc2a1b0

MON-48766

Evan-Adam force-pushed the MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected branch from 9660485 to 7c317c6 Compare July 9, 2024 15:23

fix(gorgone-tests): fix tests

5ebd34d

MON-48766

Evan-Adam force-pushed the MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected branch from 7c317c6 to 5ebd34d Compare July 10, 2024 08:23

tests(gorgone): fix process name in test

ecaca70

Refs:MON-48766

Evan-Adam marked this pull request as ready for review July 10, 2024 14:59

Evan-Adam requested review from a team as code owners July 10, 2024 14:59

Evan-Adam requested review from sdepassio, kduret and tuntoja July 10, 2024 14:59

kduret approved these changes Jul 11, 2024

View reviewed changes

sdepassio approved these changes Jul 11, 2024

View reviewed changes

mushroomempires approved these changes Jul 11, 2024

View reviewed changes

Evan-Adam and others added 2 commits July 16, 2024 09:33

Merge branch 'develop' into MON-48766-community-pr-fix-file-descripto…

3c718d2

…rs-leak-in-gorgone-that-occur-when-pollers-are-disconnected

fix(gorgone-pull): fix db filenames in tests

8de3e45

Refs:MON-48766

Evan-Adam merged commit 6258e6d into develop Jul 16, 2024
26 checks passed

Evan-Adam deleted the MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected branch July 16, 2024 15:02

Evan-Adam mentioned this pull request Aug 14, 2024

fix(gorgone): community pr fix file descriptor leak when poller are disconnected #1621

Merged

15 tasks

Evan-Adam added a commit that referenced this pull request Aug 14, 2024

fix(gorgone): community pr fix file descriptor leak when poller are d…

01bd5c6

…isconnected (#1512) Refs:MON-143753 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

Evan-Adam added a commit that referenced this pull request Aug 14, 2024

fix(gorgone): community pr fix file descriptor leak when poller are d…

2fd4f1a

…isconnected (#1512) Refs:MON-143753 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

Evan-Adam added a commit that referenced this pull request Aug 14, 2024

fix(gorgone): community pr fix file descriptor leak when poller are d…

9893edc

…isconnected (#1512) Refs:MON-143754 Co-authored-by: garnier-quentin <[email protected]> Co-authored-by: qgarnier <[email protected]>

Evan-Adam mentioned this pull request Aug 14, 2024

fix(gorgone): community pr fix file descriptor leak when poller are disconnected #1622

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected #1512

MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected #1512

Evan-Adam commented Jul 9, 2024

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

kduret left a comment

MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected #1512

MON-48766-community-pr-fix-file-descriptors-leak-in-gorgone-that-occur-when-pollers-are-disconnected #1512

Conversation

Evan-Adam commented Jul 9, 2024

Description

Type of change

Target serie

How this pull request can be tested ?

Checklist

coderabbitai bot commented Jul 9, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

kduret left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)