Update externalsnapshotter volumegroupsnapshot container arg #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In external-snapshotter the groupsnapshot feature flag is moved to a new container argument and the old enable-volumegroup-snapshot flag is removed, This PR updates the flag to use external-snapshotter latest version, Note:- As the flag is removed with Rook the user cannot test/use the older version of external-snapshotter for groupsnapshot feature, but all other features will be still supported with older releases. Signed-off-by: Madhu Rajanna <[email protected]>
updating the external-snapshotter image to the latest release. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
prep-for-external-snapshot
branch
from
728f00a to
810accd
Compare
|
external-snapshotter 8.2.0 release was done yesterday |
|
@Madhu-1 What about backward compatibility concerns? |
Alpha support is dropped in upstream, we don't need to support it as well (there is no upgrade support from alpha to beta in the external snapshotter as well. |
nb-ohad
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
In external-snapshotter the groupsnapshot feature flag is moved to a new container argument and the old enable-volumegroup-snapshot flag is removed, This PR updates the flag to use external-snapshotter latest version,
Note:- As the flag is removed from external-snapshotter the user cannot test/use the older version of external-snapshotter for groupsnapshot feature, but all other features will be still supported with older releases.
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Marking it as draft until we have next release of external-snapshotter