Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spdk related gateway server's unit tests #120

Closed
wants to merge 1 commit into from

Conversation

bwadhwa13
Copy link

This PR adds 4 unit tests related to startup and monitoring of SPDK:

  1. Gateway is able to successfully communicate with SPDK
  2. Gateway exits after SPDK hangs
  3. Gateway is able to successfully start SPDK
  4. Gateway is able to successfully shut down the SPDK

@bwadhwa13 bwadhwa13 changed the title Adding spdk gateway server unit tests Adding spdk related gateway server's unit tests May 3, 2023
@epuertat epuertat added the test label May 10, 2023
Copy link

@PepperJo PepperJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bwadhwa13 LGTM

@caroav
Copy link
Collaborator

caroav commented Aug 24, 2023

@baum please review and advise.

@baum baum force-pushed the tests branch 4 times, most recently from e640383 to eb97a33 Compare September 8, 2023 16:13
Signed-off-by: Bharti Wadhwa <[email protected]>
@baum
Copy link
Collaborator

baum commented Sep 9, 2023

Rebased and played with the tests a bit. Seems mostly covered by test_server.py

Re-open if you feel there is test logic which could be salvaged.

@baum baum closed this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants