Fastpuppi v1 dask integration #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GintasS
force-pushed
the
fastpuppi_v1_dask_integration
branch
from
be85d71 to
f272de1
Compare
cerminar
reviewed
Apr 23, 2024
| @@ -73,5 +55,4 @@ def fill_2Dhist(hist, arrayX, arrayY, weights=None): | |||
| hist.fill(flar_x, flar_y, threads=None) | |||
| else: | |||
| # ROOT.fill_2Dhist(hist=hist, arrayX=flar_x, arrayY=flar_y, weights=weights) | |||
| hist.fill(flar_x, flar_y, weights) | |||
|
|
|||
| hist.fill(flar_x, flar_y, weights) | |||
There was a problem hiding this comment.
Missing new-line at the end of file?
| aliases=name_map, | ||
| entry_start=self.file_entry, | ||
| entry_stop=self.file_entry+entry_block) | ||
| dask_akarray = NanoEventsFactory.from_root( |
There was a problem hiding this comment.
is this still up to date? did you try avoiding the loopo over the files opening all of them at once moving the NanoEventsFactory to the analyzer module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to integrate dask functionality into ntuple-analysis.
Performance sheet:
