Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS for H5Ps in Edlib #927

Closed
tmkarlsen opened this issue Mar 25, 2022 · 1 comment · Fixed by #940
Closed

CSS for H5Ps in Edlib #927

tmkarlsen opened this issue Mar 25, 2022 · 1 comment · Fixed by #940
Labels
bug Something isn't working needs triage All issues that need to be triaged by repository admins

Comments

@tmkarlsen
Copy link
Member

tmkarlsen commented Mar 25, 2022 •
edited
Loading

Look into what CSS Edlib uses for H5P
When looking at resources made within and displayed from Edlib, there are some subtile differences that some times cause problems.

We need to:

  1. Look into what CSS that are influencing this particular difference (primary objective)
  2. Document all (possible) environmental adjustments made for styling/presentation of H5Ps (secondary objective)

https://h5p.org/node/1256688
Skjermbilde 2022-03-25 kl 11 34 37

vs.
https://www.h5p-test.ndla.no/s/resources/fc546750-645e-4152-91c8-6bc601db6807

Skjermbilde 2022-03-25 kl 11 35 29

The issue was first reported here: h5p/h5p-documentation-tool#50
@tmkarlsen tmkarlsen added bug Something isn't working needs triage All issues that need to be triaged by repository admins Needs estimation This issue needs an estimated (add comment) labels Mar 25, 2022
@tmkarlsen
Copy link
Member Author

tmkarlsen commented Mar 30, 2022 •
edited
Loading

Estimate 2 weeks.
Partially solved in 1 hour.

@tmkarlsen tmkarlsen removed the Needs estimation This issue needs an estimated (add comment) label Mar 30, 2022
@emmachughes emmachughes linked a pull request Mar 30, 2022 that will close this issue
Add missing .h5p-iframe class #940
Merged
@emmachughes emmachughes mentioned this issue Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage All issues that need to be triaged by repository admins
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing .h5p-iframe class cerpus/Edlib
1 participant
@tmkarlsen