Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling eval indirectly does not reflect globally #563

Open
kyriosli opened this issue Aug 10, 2016 · 2 comments
Open

calling eval indirectly does not reflect globally #563

kyriosli opened this issue Aug 10, 2016 · 2 comments

Comments

@kyriosli
Copy link

We know that eval does not touch the local variable if it is called indirectly, for example:

(function(Math) { return (0,eval)("Math") })(1234)
// returns global.Math

and this did not work properly in v7.

@mkmik
Copy link
Collaborator

mkmik commented Aug 10, 2016

yeah, it's a known problem. We currently treat eval as a normal function.
This issue will be fixed when we finally implement compact stack frames for function calls; for that to work we'll have to treat explicit calls to eval specially (and thus indirectly also fix this test-case).
No ETA for the moment.

@mkmik
Copy link
Collaborator

mkmik commented Aug 10, 2016

BTW, @kyriosli, what is your use case ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants