-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dio] Test typed responses #1755
Conversation
2c5e5fe
to
fa39db6
Compare
fa39db6
to
72fe7d2
Compare
72fe7d2
to
3f9e941
Compare
Really would love some feedback here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely a significant step forward for the package. So everyone should write request<String?>
instead of request<String>
, right? If they upgraded without thinking, this might produce much NPE during the runtime?
The change is great, but we might evaluate the cost for the whole ecosystem. |
I agree that this can break. So we need good examples in the 6.0.0 migration docs. But users who have handling for nullable responses via |
I added a changelog and some basic samples to the migration docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR relates to #1335 and is for now just meant as idea and for further testing.
But correctly typed responses do work.
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)