Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to browser tests #1966

Closed
wants to merge 3 commits into from
Closed

Updates to browser tests #1966

wants to merge 3 commits into from

Conversation

kuhnroyal
Copy link
Member

Not sure if we want to run all tests on firefox but I guess it doesn't hurt.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal added the p: dio Targeting `dio` package label Sep 13, 2023
@kuhnroyal kuhnroyal self-assigned this Sep 13, 2023
@kuhnroyal kuhnroyal mentioned this pull request Sep 13, 2023
Merged
7 tasks
@kuhnroyal
Copy link
Member Author

Closing this, since everything is addressed in #1955

@kuhnroyal kuhnroyal closed this Sep 14, 2023
@kuhnroyal kuhnroyal deleted the browser-tests branch September 14, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kuhnroyal kuhnroyal

Labels
p: dio Targeting `dio` package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kuhnroyal