-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converge melos usage and CI scripts & add code coverage #2136
Conversation
* move all scripts to melos and make them available for usage locally * automatically generation coverage information for all Dart tests (vm, chrome, firefox) * print coverage results to CLI for stable SDK
This reverts commit ab20bd7.
There are currently random test timeouts due to network/httpbun but I think this is good to go. |
3bbb4a2
to
3fa6c9a
Compare
@cfug-dev Looking for feedback on this change. I have a follow-up which moves most of the tests to a local httpun docker container in CI, which is based on this. |
This look fantastic and those scripts become elegant! Two more things might be added to the README too:
|
Added individual melos scripts for firefox/chrome and renamed |
I added a |
I don't want to add anything about coverage yet, maybe when it has settled and is working as expected in PRs. |
Could we also have a Chinese version? The library is widely used in the Chinese community. Adding the translation within the same file or make a separate file both look good to me. |
Would you mind adding a |
That would be nice too. |
This should also address #2136. |
Can you write/translate that file or should I just ask ChatGPT? :D |
Yeah please go ahead and let GPT helps |
That is this PR :) Add a Chinese version, can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
The idea of this PR is to make it easier to run tests locally based on melos while also adding code coverage reporting.
I want to further extend the coverage reporting by using https://github.com/clearlyip/code-coverage-report-action.
This action would run for each push/merge to the main branch an generate a constant coverage baseline for the main branch. The baseline is uploaded as workflow artifact and as such available to pull request which can then display the change in coverage.
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)