Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @pragma('vm:awaiter-link') for better stacktraces #2292

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use @pragma('vm:awaiter-link') for better stacktraces #2292

wants to merge 1 commit into from
+14 −0

Conversation

codedbycurtis
Copy link

Added the @pragma('vm:awaiter-link') annotation to each instance of Completer.
Closes #2291.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

N/A

@codedbycurtis codedbycurtis requested a review from a team as a code owner September 11, 2024 23:49
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 84.46% 🟢 84.46% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 84.46%

@AlexV525
Copy link
Member

Could you also add tests to make sure stack traces have been improved?

@ueman
Copy link
Contributor

ueman commented Sep 12, 2024 •
edited
Loading

Tests should be fairly straightforward to add. Just make the various cases throw an exception and call toString() on the stacktrace. Also make sure the stacktraces are actually better than before.

The ones in the test suite probably don't need tests, though

@AlexV525
Copy link
Member

@codedbycurtis Still going to work on this?

@codedbycurtis
Copy link
Author

@AlexV525 Apologies for the lack of updates on this. I tried to implement these tests a few weeks ago but was having trouble getting the tests to run with melos (something regarding invalid filters so probably just some obscure configuration issue on my end), and have not had the time recently to look into the issue. I am happy enough if someone else wants to take over and look into getting these tests added.

@AlexV525 AlexV525 marked this pull request as draft December 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use @pragma('vm:awaiter-link') for better stacktraces
3 participants
@codedbycurtis @AlexV525 @ueman