Dual Quaternion Skinning #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrocnic
changed the title
…l quat shader code with code from a different source (https://github.com/pmbittner/OptimisedCentresOfRotationSkinning). The artifacts are gone. (Went through hours of debugging using RenderDoc and debug printfs, still did not find the reason why the old code would produce artifacts. Just found that it would occur in dualquat_add where the dot product is smaller than 0. However, could not fix it. Exchanging the code fixed it, but that part remained. This means that the miscalculation happened somewhere earlier. Also it must happen in the shader code and not in the cpp code, else this exchange would not have fixed it.
|
Please beware of issue #100 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.