Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing Docker image for the frontend #30

Open
jeliasson opened this issue Apr 6, 2020 · 2 comments
Open

Finalizing Docker image for the frontend #30

jeliasson opened this issue Apr 6, 2020 · 2 comments

Comments

@jeliasson
Copy link

jeliasson commented Apr 6, 2020

Hi all,

I'm working on a Docker image for the frontend, but I'm having problems with manifest.json not being part of the dist/ directory after yarn build. Any thoughts?

See my pull request on covid-self-report-mlt/self-report-frontend.

❤️

@mullerch
Copy link
Member

mullerch commented Apr 6, 2020

Well, there is actually no manifest file 😄

It look like you have another problem, but it's hard to see what with the prod build. Try with 'yarn serve'

@jeliasson
Copy link
Author

Well, there is actually no manifest file 😄

It look like you have another problem, but it's hard to see what with the prod build. Try with 'yarn serve'

Isn’t yarn serve for development purposes? This image is intended for production deployment, and thus having the dist/ directory created that statically being served by nginx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants