-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Going forward #1
Comments
I think the first things we should go over is defining the limits of the project and merging the pull requests that fit. We should probably also aim for a stable version 1.0.0 as soon as possible. I'm pretty sure I'm not the only one to relie on this library in production already. |
Thank you for taking the lead here, @ch2877!
I agree with this. At least these three pull requests seem to contain necessary changes for the future. Their developers likely will have to create a new pr here?
Yep, then making it a v1.0 would be good. Everything that is in production should be 1.0 at least, no matter whether it's feature-complete or not. Also, the README should be updated to make clear that this is the new fork that will be maintained. And a PR should be made to the original repository to link here in their README. |
I agree with 1.0.0 as the bump to PHP 8.0 will mean that we need to add some breaking changes due to the reserved words. I think we will also have to change the package name as we can’t submit it to packagist with the same name as before. This brings up the question if we also need to change the root namespace to avoid collisions with the old package? …. This will also be a breaking change. I suggest the following:
|
I suppose this would be
I don‘t see a need for this besides cosmetic reasons to match the new package name. Therefore I‘d consider it an unnecessary bc break and would advise against it. |
Thank you for quickly merging the first pr #2. How do we want to handle releases and other decisions on this library? Are we all equals who can act independently, do we need some kind of voting system or should it eventually be @ch2877 as owner of the repo to make final decisions? I don't really have any experience in being an oss maintainer as part of a group. |
I can add the package to packagist, however I would prefer if we had PHP 8 compatibility first as this this will contain breaking changes. |
I don't see this as a requirement for a v1.0, but it's fine with me to wait for those changes if they can be implemented soon.
I agree with this. |
@sprain |
Could we please briefly discuss how to move forward?
I have not published anything to packagist yet.
The text was updated successfully, but these errors were encountered: