Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the stream info from pyflowline #9

Open
changliao1025 opened this issue Aug 18, 2022 · 3 comments
Open

Preserve the stream info from pyflowline #9

changliao1025 opened this issue Aug 18, 2022 · 3 comments

Comments

@changliao1025
Copy link
Owner

The json file from PyFlowline contains a flag on whether a cell is a stream grid or not. However, the flow accumulation is also used to define the stream grid. To preserve the original information, it is better to keep the flag even though its accumulation may be smaller than the threshold.

@changliao1025
Copy link
Owner Author

This is the place that may need improvement.

if ((vCell_active.at(lCellIndex_self)).iFlag_stream_burned == 1)

@changliao1025
Copy link
Owner Author

However, it is also possible to adjust the threshold during the simulation.
Such this parameter should consider the minimal flow accumulation in those burnt in cells.

@changliao1025
Copy link
Owner Author

We decide to use a new added option (iFlag_stream_grid_option) to control this feature to allow flexibility.

  1. iFlag_stream_grid_option is 1: only burnt in stream cells are defined as stream cells.
  2. iFlag_stream_grid_option is 2: only cells which have higher accumulation than threshold are defined as stream cells.
  3. iFlag_stream_grid_option is 3: both cells which have higher accumulation than threshold and burnt in cells are defined as stream cells.
  4. iFlag_stream_grid_option is 4: similar to 3, but the the threshold is dynamically changed based on the actual flow accumulation of burnt in cells.

Because HexWatershed can turn off stream burning, not all options are available in different configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant