Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace InputSearch's Clear Icon with SDS xMark Icon #606

Closed
masoudmanson opened this issue Sep 21, 2023 · 0 comments · Fixed by #607
Closed

Replace InputSearch's Clear Icon with SDS xMark Icon #606

masoudmanson opened this issue Sep 21, 2023 · 0 comments · Fixed by #607
Assignees
@masoudmanson
Labels
Eng Feature Request

Comments

@masoudmanson
Copy link
Contributor

masoudmanson commented Sep 21, 2023 •
edited
Loading

When text is entered into the InputSearch component, you may have noticed the default HTML clear icon. However, this default icon doesn't align with our SDS iconography. To improve consistency and visual coherence, we need to replace the default clear icon with the SDS xMark icon.

Current InputSearch:

Desired Result:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masoudmanson masoudmanson

Labels
Eng Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(inputsearch): change default html clear icon chanzuckerberg/sci-components
1 participant
@masoudmanson