feat(menuitem): add determinate/indeterminate variant to the MenuItem #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masoudmanson
deleted the
601-add-determinateindeterminate-variant-to-the-menuitem-component
branch
tihuan
reviewed
Sep 21, 2023
| @@ -110,9 +110,9 @@ | |||
| "build-storybook": "storybook build -o docs-build", | |||
| "test-storybook": "test-storybook", | |||
| "storybook:axe": "yarn build-storybook && yarn storybook:axeOnly", | |||
| "storybook:axeOnly": "axe-storybook --build-dir docs-build", | |||
| "storybook:axeOnly": "axe-storybook --build-dir docs-build --timeout 10000", | |||
There was a problem hiding this comment.
Thanks for adding this, @masoudmanson !
We can probably remove the following config in test files now we set the flag globally!
axe: {
timeout: 10 * 1000,
},There was a problem hiding this comment.
Ah, you're right.
We don't even need a global timeout config. I'll revert this change and set a timeout for that specific component. 😯😥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MenuItem
Github issue: #601
As part of implementing the new Multi-column dropdown, we need to temporarily introduce a determinate/indeterminate variant for the MenuItem component. This change is temporary as we're planning to use the InputCheckbox component inside the MenuItem component to handle checkbox states instead of directly managing them within the MenuItem component.
Checklist
defaultTheme.tsused wherever possible