feat(InputCheckbox): refactor InputCheckbox
and InputRadio
#904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge only after #902 has been merged.
Summary
InputCheckbox & InputRadio
Github issue: #903
The current SDS control icons need to be updated to use JSX elements with the new
Check
icon. The issue with the current implementation is that the checked checkbox is hollow, allowing the background color to show through. This causes design inconsistencies when the checkbox is placed on backgrounds other than white (in light mode) or black (in dark mode).To resolve this, the checkbox design should be updated to feature a solid filled square with the
Check
icon overlayed on top. The icon’s color should dynamically adjust based on the theme to ensure consistency across different background colors.The same changes are needed for the
InputRadio
component.Checklist
defaultTheme.ts
used wherever possible