Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfishpower: add -x,--exclude-plugs option #175

Open
garlick opened this issue Apr 11, 2024 · 5 comments
Open

redfishpower: add -x,--exclude-plugs option #175

garlick opened this issue Apr 11, 2024 · 5 comments

Comments

@garlick
Copy link
Member

garlick commented Apr 11, 2024

Problem: it's kind of janky to have to make up hostname placeholders like unused[0-7] for unused blade slots in the cray-ex chassis.

I can't remember if we discussed this before and decided against it, but would it make sense to have a redfishpower -x,--exclude-plugs option so those placeholders would not be needed? For example if Blade[4-7] are unpopulated thus Node[8-15] do not require host mappings, instead of:

device "chassis0" "cray-ex" "/usr/sbin/redfishpower -h cmm0,pnode[0-7],unused[0-7] |&"

you could do:

device "chassis0" "cray-ex" "/usr/sbin/redfishpower -x Node[8-15] -h cmm0,pnode[0-7]|&"
@chu11
Copy link
Member

chu11 commented Apr 11, 2024

My initial thought was "does it actually make the config easier?" It seems like a sideways move to me overall.

@garlick
Copy link
Member Author

garlick commented Apr 11, 2024

What could go wrong :-) . Why is my misconfigured powerman daemon sending http requests to "unknown15"?

@chu11
Copy link
Member

chu11 commented Apr 12, 2024

per some offline thoughts / discussion

implementation can get a little tricky, b/c of parenting. for example, if user does --excldude=Blade6, that means that not only Blade6 is not a valid plug, but Node12 & Node13 are also invalid.

Hypothetically making it so exclude only works with "leaf" plugs makes things easier, but there's no way to know what a leaf is until all configuration is complete (which is in login script, well after command line parsing is done).

@chu11
Copy link
Member

chu11 commented Apr 12, 2024

A completely random, possibly bad idea. What if we made a certain keyword a special case for "unused". Like

-h cmm0,pnode[0-7],UNPOPULATED[0-7]

and redfishpower would know "never send a message to UNPOPULATED"?

@garlick
Copy link
Member Author

garlick commented Apr 12, 2024

Eh, that still feels pretty hacky for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants