Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charcoal/email] Allow email view controller to be customizable #78

Open
mcaskill opened this issue Nov 29, 2023 · 0 comments
Open

[charcoal/email] Allow email view controller to be customizable #78

mcaskill opened this issue Nov 29, 2023 · 0 comments

Comments

@mcaskill
Copy link
Collaborator

The ViewableTrait allows one to customize the view controller used in rendering a template path identifier. By default, the view controller is the instance that implements the trait.

In Email, the accessor method is overridden—since its inception—which forces one to create a template controller for each template path identifier; without extending the Email class.

I don't know why this decision was made but it is annoying and restricts customization and flexibility.

For example, it would be practical to have a single project-side template controller and many different template files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant