Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimization suggestions #548

Open
noobyu6 opened this issue Jun 8, 2022 · 0 comments
Open

Code optimization suggestions #548

noobyu6 opened this issue Jun 8, 2022 · 0 comments

Comments

@noobyu6
Copy link

noobyu6 commented Jun 8, 2022

Is your feature request related to a problem? Please describe.
private field can be replaced by a local variable

Describe the solution you'd like
private field can be replaced by a local variable

Describe alternatives you've considered
private field can be replaced by a local variable

Additional context
Hi,

I find that the private field iupac at Line 28 in the file 'jannovar/jannovar-hgvs/src/main/java/de/charite/compbio/jannovar/hgvs/Translator.java ' on the main branch is only assigned and used in the method initializeMaps . Therefore, this field can be removed from the class, and become a local variable in the method initializeMaps. This transformation will normally reduce memory usage and improve readability of your code.I will be happy if this transformation is helpful.

private ImmutableMap<String, String> iupac = null; // line 28 this field can be replaced by local variable

private void initializeMaps() {
  	...
    //   ImmutableMap<String, String> iupac = iupac.build();
    this.iupac = iupac.build(); // line 315
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant