Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better naming #1

Open
Edvinas01 opened this issue Oct 5, 2023 · 0 comments
Open

Use better naming #1

Edvinas01 opened this issue Oct 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Edvinas01
Copy link
Member

Edvinas01 commented Oct 5, 2023 •
edited
Loading

There is a set of methods/classes that I think are named poorly. For example:

  • IFixedUpdateListener.OnFixedUpdated - doesn't read well (compare it to `IUpdateListener.OnUpdated).
  • GameManager.OnBeforeInitializeSystems - doesn't communicate well enough that this is the place to initialize game manager.
  • GameManager.OnAfterInitializeSystems - similar the one above.

There are more things that could be named better, though these were on top of my head for now...

So:

  • Propose and use better naming.
  • Update documentation.
@Edvinas01 Edvinas01 added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Edvinas01