"Set Color" and "Set Icon" only uses text to display option to the user.

[ReticentAdjutant]

Wow. First? Woot.

What Happens
"Set Color" and "Set Icon" only uses text to display option to the user. No color or icons are actually displayed to the user when changing them for any given container.

What's Expected
For the sake of readability, when changing settings, options displayed should do so in a contextually appropriate way, i.e., displaying the color for each color option and displaying the icon for each icon option.

Perceived Options
You could just bold and colorize the text for the color options but for the sake of consistency that may be less than ideal when resolving how to handle the icons options. Assuming the menu flow stays the same, it may be best to simply append the filled in circle icon the native containers addon uses to delineate colors to the beginning of each color option, filled in with the appropriate color. I think this would provide the most consistency when addressing the same issue with displaying the icons for the icon options. Of course, you could change the menu flow to just use icons and remove the text for both altogether. It would probably mean changing the way the options are displayed entirely however: a vertical list with all that space next to it might look funny. I'm no coder so I'm not sure if changing the menu flow for the entire addon is worth the trouble. I will say that the menu flow for the native container addon was done well, however. No superfluous space, relatively compact design, no compromises on clarity because just icons. I'm just not sure what that would mean for the point of your addon even if you were to decide to copy it.

[charles-m-knox]

Wow. First? Woot.

Hehe, I'm honored.

"Set Color" and "Set Icon" only uses text to display option to the user. No color or icons are actually displayed to the user when changing them for any given container.

Can confirm that I coded it this way for a reason. I wanted to get an MVP (minimum viable product) out the door without spending too much effort on making a UI dialog for it (the current dialog is a basic text-only dialog and ships natively with your browser). This is purely the result of tech debt - at the time, I wasn't sure if the extension would get users, so I decided to keep it "simple enough".

I completely agree with you though, and I want to implement this. I'll put it on the todo list.

Regarding displaying the icons, the source SVG files appear to be embedded as part of the original multi-account containers addon. I hesitated to simply copy the icons into this addon because I was worried they'd change them out from under me. It's possible my concern is simply not a big enough deal to matter (they may keep the icons the same forever).

Thank you for creating the first issue! I'll take your feedback into my next round of work on the addon.

[ReticentAdjutant]

Regarding displaying the icons, the source SVG files appear to be embedded as part of the original multi-account containers addon. I hesitated to simply copy the icons into this addon because I was worried they'd change them out from under me. It's possible my concern is simply not a big enough deal to matter (they may keep the icons the same forever).

Forgive me if this is a dumb question but can you just refer to them? Like instead of putting them in your addon can you call for a reference? That way even if they change them the references will (probably) stay the same? Or is that a barrier you can't cross?

[charles-m-knox]

That way even if they change them the references will (probably) stay the same? Or is that a barrier you can't cross?

I'm not 100% certain at this moment if I can just refer to them. It's been a few months, but when I was coding everything up, I think I tried it and it didn't cooperate. I definitely will look into this.