Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo support #860

Closed
PhilGarb opened this issue Sep 25, 2023 · 6 comments
Closed

Monorepo support #860

PhilGarb opened this issue Sep 25, 2023 · 6 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@PhilGarb
Copy link

What problem does this feature solve?

We are using a Monorepo and would love to adopt checkly. However the constrained on the usable dependencies makes it hard to adopt for us. Local monorepo packages are basically just source code and not really a dependencies that could not be supported by the cli as long as the packages dependencies conform to the runtime.
Being able to use local packages would allow us to adopt checkly.

How would you implement this feature?

I am not sure how checkly handles the check for allowed dependencies, but should it not be possible to allow all packages from a specific org? Usually local monorepo packages follow the @company/* naming convention. Filtering these allowed dependencies based on such a glob would be easy. They could then be inlined and the result be checked for the runtime requirements.

@PhilGarb PhilGarb added the enhancement New feature or request label Sep 25, 2023
@tnolet
Copy link
Member

tnolet commented Sep 27, 2023

Hey @PhilGarb which packages do you import into your .check.ts and .spec.ts files that we currently don't support?

@PhilGarb
Copy link
Author

PhilGarb commented Sep 30, 2023

I have a test like this:

import { pwTest } from "@mioto/test-utils";

pwTest("should start test", async ({ anonymusUser }) => {
  await anonymusUser.goto("dashboard");
});

Where @mioto/test-utils is an internal dependency that resolves to packages/test-utils/src/index.ts. I do not want you to support this specific package, but rather the concept of local packages in general. This is source code that might as well be part of the checkly test file itself, but then it would not properly work as a dependency for other situations.

@PhilGarb
Copy link
Author

Just checking is there anything that can be done here?

@tnolet
Copy link
Member

tnolet commented Jan 15, 2024

Just checking is there anything that can be done here?

Hey @PhilGarb is your project open source so we can have a look at the setup?

@PhilGarb
Copy link
Author

It is not open source, but I could create a reproduction. It is basically a standard nx monorepo setup where the local dependencies are imported through typescript paths.

@sorccu sorccu added the duplicate This issue or pull request already exists label Jan 2, 2025
@sorccu
Copy link
Collaborator

sorccu commented Jan 2, 2025

I believe this may be a duplicate of #884 which is currently being worked on in #1006. While some work still remains, I think we will have it officially available in a few weeks.

If I am mistaken then please reopen the ticket and provide a little additional context, such as what exactly you are using to allow the import resolution to work if not tsconfig paths.

@sorccu sorccu closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants