Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch-diff-report-tool: shorten file names is not doing anything #900

Open
rnveach opened this issue Aug 29, 2024 · 1 comment
Open

Patch-diff-report-tool: shorten file names is not doing anything #900

rnveach opened this issue Aug 29, 2024 · 1 comment

Comments

@rnveach
Copy link
Member

rnveach commented Aug 29, 2024

https://github.com/checkstyle/contribution/blob/master/patch-diff-report-tool/src/main/java/com/github/checkstyle/site/SiteGenerator.java#L219

Example:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7e9dba3_2024170824/reports/diff/checkstyle/index.html#Violations

/home/runner/work/checkstyle/checkstyle/.ci-temp/contribution/checkstyle-tester/repositories/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/fallthrough/InputFallThrough4.java

Example from my launch script:

src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/treewalker/InputTreeWalkerSkipParsingExceptionConfigSeverityIgnore.java

My launch scripts don't have this issue but I don't remember how it was resolved. It could be because they are running checkstyle directly and groovy is still calling the maven plugin.

@rnveach
Copy link
Member Author

rnveach commented Aug 30, 2024

File names in report are shortened at

filename = refFilesPath.relativize(Paths.get(filename)).toString();
.

I assume our GH action isn't working with this, while the diff scripts are, is because of the maven plugin and files have to be copied to a different location to be run on. The diff scripts run CS directly on the folder they are cloned from.

Also this is not very well documented effect at https://github.com/checkstyle/contribution/tree/master/patch-diff-report-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant