Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for overlapping methods and attributes machine_batch / chef_server / machine_options / image_options #429

Open
tyler-ball opened this issue Sep 3, 2015 · 4 comments
Labels
Triage: Confirmed Indicates and issue has been confirmed as described. Type: Bug Doesn't work as expected.

Comments

@tyler-ball
Copy link
Contributor

In https://github.com/chef/chef-provisioning/blob/4638bdf99e048452b5b80e06c118ba2a0a0132a3/lib/chef/provisioning/chef_run_data.rb and https://github.com/chef/chef-provisioning/blob/4638bdf99e048452b5b80e06c118ba2a0a0132a3/lib/chef/provisioning/recipe_dsl.rb we provide helper methods to define globals which merge with certain attributes. Unfortunately, there is not sufficient testing or documentation on how this is supposed to work.

How do the attributes in the machine_batch get merged down to the individual machines? What about actions? How does CP automatically batch individual machines?

Related:

#78
#376
#378
#383
#413
#422
#438
#448
#455
chef-boneyard/chef-provisioning-aws#306

This probably deserves its own EPIC

@hh
Copy link
Contributor

hh commented Nov 16, 2015

Do we have an EPIC for this yet?

@tyler-ball
Copy link
Contributor Author

@hh unfortunately not - we're working on non-provisioning stories for the foreseeable future

@hh
Copy link
Contributor

hh commented Nov 26, 2015

I'm not sure what you mean by non-provisoning... non chef-provisoning?

@tyler-ball
Copy link
Contributor Author

@hh Yes, non chef-provisioning work

@tas50 tas50 added Type: Bug Doesn't work as expected. Status: Confirmed and removed Bug labels Jul 31, 2018
@tas50 tas50 added Triage: Confirmed Indicates and issue has been confirmed as described. and removed Status: Confirmed labels Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Confirmed Indicates and issue has been confirmed as described. Type: Bug Doesn't work as expected.
Development

No branches or pull requests

3 participants