Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reap failure can show red herring error message #144

Open
coderanger opened this issue Jun 10, 2017 · 0 comments
Open

Reap failure can show red herring error message #144

coderanger opened this issue Jun 10, 2017 · 0 comments
Labels
Type: Bug Does not work as expected.

Comments

@coderanger
Copy link
Contributor

If an exception is raised during run_command, we try to reap things, it will show a red herring error log that "Command exceeded allowed execution time" even though the timeout wasn't involved. We should differentiate the log message on the two places we use reap_errant_child.

In this case the exception was being raised by a faulty live_stream implementation, but there are others.

@tas50 tas50 added the Type: Bug Does not work as expected. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

No branches or pull requests

2 participants