From fd194bc4f6ec56a825016252ab4862355e2215b8 Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Wed, 21 Oct 2020 04:01:34 -0400 Subject: [PATCH] Added PAGE_LINK_PATHPREFIX preference for specifying Android pathPrefix (#82) * Added PAGE_LINK_PATHPREFIX preference for specifying Android pathPrefix * Added FirebaseDynamicLinksCustomDomains to iOS Info.plist * Refactor preferences to APP_DOMAIN_NAME and APP_DOMAIN_PATH * Update README.md for APP_DOMAIN_NAME and APP_DOMAIN_PATH changes * Fixed APP_DOMAIN_PATH typo in README.md example * Append APP_DOMAIN_PATH to DOMAIN_URI_PREFIX --- README.md | 8 ++++++-- plugin.xml | 22 +++++++++++++++------- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 6365a29..8a062e9 100644 --- a/README.md +++ b/README.md @@ -21,9 +21,13 @@ ## Installation - $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable PAGE_LINK_DOMAIN="mydomain.page.link" + $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable APP_DOMAIN_NAME="mydomain.page.link" -Use variable `PAGE_LINK_DOMAIN` specify your `*.page.link` domain. +Use variable `APP_DOMAIN_NAME` to specify your Google generated `*.page.link` domain or other custom domain. + + $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable APP_DOMAIN_NAME="mydomain.com" --variable APP_DOMAIN_PATH="/app1" + +Use variables `APP_DOMAIN_PATH` to speciy a specific domain path prefix when using a custom domain. This is useful if multiple apps share the same root level domain. If specified this path **must** begin with a `/`. Use variables `IOS_FIREBASE_DYNAMICLINKS_VERSION` and `ANDROID_FIREBASE_DYNAMICLINKS_VERSION` to override dependency versions for Firebase SDKs. diff --git a/plugin.xml b/plugin.xml index 4f77d83..0cd1259 100644 --- a/plugin.xml +++ b/plugin.xml @@ -18,7 +18,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" - + + @@ -26,7 +27,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" - + @@ -37,8 +38,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" - - + + @@ -54,7 +55,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" - + @@ -75,15 +76,22 @@ xmlns:android="http://schemas.android.com/apk/res/android" + + + http://$APP_DOMAIN_NAME$APP_DOMAIN_PATH + https://$APP_DOMAIN_NAME$APP_DOMAIN_PATH + + + - applinks:$PAGE_LINK_DOMAIN + applinks:$APP_DOMAIN_NAME - applinks:$PAGE_LINK_DOMAIN + applinks:$APP_DOMAIN_NAME