From 58893a06c8bda908b64a62ed9b6d5ee4ad2be795 Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Sun, 4 Oct 2020 10:42:26 -0400 Subject: [PATCH 1/6] Added PAGE_LINK_PATHPREFIX preference for specifying Android pathPrefix --- plugin.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugin.xml b/plugin.xml index 11649b0..1effb81 100644 --- a/plugin.xml +++ b/plugin.xml @@ -19,6 +19,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" + @@ -37,8 +38,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" - - + + From c1090947ca78cf6aa5d13b5c70028226544164c2 Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Mon, 12 Oct 2020 11:04:13 -0400 Subject: [PATCH 2/6] Added FirebaseDynamicLinksCustomDomains to iOS Info.plist --- plugin.xml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/plugin.xml b/plugin.xml index 1effb81..62ee2aa 100644 --- a/plugin.xml +++ b/plugin.xml @@ -76,6 +76,13 @@ xmlns:android="http://schemas.android.com/apk/res/android" + + + http://$PAGE_LINK_DOMAIN/PAGE_LINK_PATHPREFIX + https://$PAGE_LINK_DOMAIN/PAGE_LINK_PATHPREFIX + + + applinks:$PAGE_LINK_DOMAIN From 3cf532a365465eae892e24b0f1bb1d8d7ab43215 Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Mon, 12 Oct 2020 11:08:17 -0400 Subject: [PATCH 3/6] Refactor preferences to APP_DOMAIN_NAME and APP_DOMAIN_PATH --- plugin.xml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/plugin.xml b/plugin.xml index 62ee2aa..816776e 100644 --- a/plugin.xml +++ b/plugin.xml @@ -18,8 +18,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" - - + + @@ -27,7 +27,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" - + @@ -38,8 +38,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" - - + + @@ -55,7 +55,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" - + @@ -78,20 +78,20 @@ xmlns:android="http://schemas.android.com/apk/res/android" - http://$PAGE_LINK_DOMAIN/PAGE_LINK_PATHPREFIX - https://$PAGE_LINK_DOMAIN/PAGE_LINK_PATHPREFIX + http://$APP_DOMAIN_NAME$APP_DOMAIN_PATH + https://$APP_DOMAIN_NAME$APP_DOMAIN_PATH - applinks:$PAGE_LINK_DOMAIN + applinks:$APP_DOMAIN_NAME - applinks:$PAGE_LINK_DOMAIN + applinks:$APP_DOMAIN_NAME From 1903a7a45831394b77aa84a79d67588250f0dd71 Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Mon, 12 Oct 2020 11:56:17 -0400 Subject: [PATCH 4/6] Update README.md for APP_DOMAIN_NAME and APP_DOMAIN_PATH changes --- README.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0d3e637..c0702bd 100644 --- a/README.md +++ b/README.md @@ -24,9 +24,13 @@ ## Installation - $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable PAGE_LINK_DOMAIN="mydomain.page.link" + $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable APP_DOMAIN_NAME="mydomain.page.link" -Use variable `PAGE_LINK_DOMAIN` specify your `*.page.link` domain. +Use variable `APP_DOMAIN_NAME` to specify your Google generated `*.page.link` domain or other custom domain. + + $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable APP_DOMAIN_NAME="mydomain.com" APP_DOMAIN_PATH="/app1" + +Use variables `APP_DOMAIN_PATH` to speciy a specific domain path prefix when using a custom domain. This is useful if multiple apps share the same root level domain. If specified this path **must** begin with a `/`. Use variables `IOS_FIREBASE_DYNAMICLINKS_VERSION` and `ANDROID_FIREBASE_DYNAMICLINKS_VERSION` to override dependency versions for Firebase SDKs. From 470fb1caa09b05ec9d4a917066d728c4eeb7f5e1 Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Mon, 12 Oct 2020 12:02:09 -0400 Subject: [PATCH 5/6] Fixed APP_DOMAIN_PATH typo in README.md example --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c0702bd..f1f178e 100644 --- a/README.md +++ b/README.md @@ -28,7 +28,7 @@ Use variable `APP_DOMAIN_NAME` to specify your Google generated `*.page.link` domain or other custom domain. - $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable APP_DOMAIN_NAME="mydomain.com" APP_DOMAIN_PATH="/app1" + $ cordova plugin add cordova-plugin-firebase-dynamiclinks --variable APP_DOMAIN_NAME="mydomain.com" --variable APP_DOMAIN_PATH="/app1" Use variables `APP_DOMAIN_PATH` to speciy a specific domain path prefix when using a custom domain. This is useful if multiple apps share the same root level domain. If specified this path **must** begin with a `/`. From 93b5e30622bb1b202bebf1851a099adfb0d8099a Mon Sep 17 00:00:00 2001 From: Joshua McFarland <4167341+mcfarljw@users.noreply.github.com> Date: Tue, 20 Oct 2020 10:53:20 -0400 Subject: [PATCH 6/6] Append APP_DOMAIN_PATH to DOMAIN_URI_PREFIX --- plugin.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin.xml b/plugin.xml index 816776e..8b2e7dc 100644 --- a/plugin.xml +++ b/plugin.xml @@ -27,7 +27,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" - + @@ -55,7 +55,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" - +