Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design callback based API #609

Open
kanru opened this issue Jul 15, 2024 · 0 comments
Open

Design callback based API #609

kanru opened this issue Jul 15, 2024 · 0 comments
Milestone

Comments

@kanru
Copy link
Member

kanru commented Jul 15, 2024

          > I guess for chewing you may want to only show aux/notification when calling the handle_* API, not the set_* that modifies the state directly.

This is a good point.

Callback based API sounds good but we need to think about issues like function reentrant and multi-threading.

For now I'm thinking to stick with current approach and explore callback based design post-1.0 deprecated API clean-up.

Originally posted by @kanru in #506 (comment)

@kanru kanru added this to the v0.10.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant