-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken tests in html-macro 0.7.0 and 0.7.1 #170
Comments
Right now text works slightly differently on stable vs. nightly. One approach would be to add a |
Aah, that explains it! I previously used nightly, but migrated to stable recently. The tests pass on nightly (except for one test that does assertions with regards to error message output.)
That would be nice. Or a |
The quoting workaround is a bit awkward due to double curly braces when using top-level text:
However, I guess we'll have to live with this limitation for now. |
There shouldn't be a fundamental reason that we couldn't support I'm also realizing that we shouldn't need a feature flag. If you aren't on nightly then |
I upgraded to html-macro 0.7.1, but my project testsuite started failing due to the way spaces are handled.
So as a sanity-check, I ran the tests in percy itself:
It seems like a lot of tests are failing. This happens on commit 2aed654 (0.7.0) as well.
The text was updated successfully, but these errors were encountered: