Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using typed-html #52

Closed
dbrgn opened this issue Dec 5, 2018 · 8 comments
Closed

Using typed-html #52

dbrgn opened this issue Dec 5, 2018 · 8 comments

Comments

@dbrgn
Copy link
Collaborator

dbrgn commented Dec 5, 2018

Since the current html! macro seems incomplete (see #51), what about integrating https://docs.rs/typed-html/0.1.1/typed_html/index.html instead?

The tree could be generated by walking the result of the vdom method.

@chinedufn
Copy link
Owner

This would certainly save time if it was that straightforwards!

My one question - would this support web_sys events? I see that typed-html seems to lean towards stdweb but I haven't read over the implementation.

I think that we want to be fully based on web_sys so that would be the only blocker here I think.

@dbrgn
Copy link
Collaborator Author

dbrgn commented Dec 5, 2018

Hm, it does look like the events are tied to stdweb...

Maybe another option would be to support both stdweb and web_sys events in typed-html using compile flags? Ping @bodil, would this be something you'd consider?

@dbrgn
Copy link
Collaborator Author

dbrgn commented Jan 17, 2019

I opened an issue at bodil/typed-html#33.

@chinedufn
Copy link
Owner

Awesome!

@chinedufn
Copy link
Owner

chinedufn commented Jan 25, 2019

I've begun working on a procedural html! macro that that will use the web_sys event types. Progress can be followed here https://github.com/chinedufn/percy/compare/proc-macro

I'll PR it once it hits feature parity with the current macro_rules!.

@dbrgn
Copy link
Collaborator Author

dbrgn commented Jan 25, 2019

@chinedufn awesome!

@chinedufn
Copy link
Owner

Closing this in favor of #59

I'm thinking that we can open issues one by one for specific compile time checks that we'd like to have.

Thanks so much for opening this issue!

@chinedufn
Copy link
Owner

Actually, @dbrgn mind giving #59 a quick scan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants