Recommendations

[james-pre]

A few recommendations for your project:

• Formatting

More readable code results in more readable code and faster programming (#2)

• Code aesthetic

Lots of things (e.g. guard clauses, inversion, ES6 style programming, etc.) can make the code more readable and less prone to errors. I have a few video recommendations:

• Naming Things in Code

• Why You Shouldn't Nest Your Code

• Don't Write Comments

• Dependencies in source control

I've noticed you have some code dependencies committed to source control (src/assets). From personal experience, I strongly recommend you don't do this.

• To-do tracking

I recommend you track to-do items using Github issues instead of using source control, again from personal experience.

• Branch names

I find your branch names to be difficult to understand and use, and think other developers would have the same experience. I recommend you don't use number prefixes and do use kebab case (convention, this is something-like-this, lower case with dashes).

[chinonso098]

Thank you very much for the suggestions and modifications, It is greatly appreciated

[chinonso098]

Did you encounter the 'no such file or directory' error?

[chinonso098]

Hi there, @james-pre. I just wanted to check-in an see if you did encounter the 'no such file or directory' error?

I haven't touched the code since last week (took a little break). But I will be getting back into it shortly. Again, thanks for all the changed you've made, i'll pull it down and give it a spin

[james-pre]

FYI You will need to update the build system to work with the NPM dependencies.

I haven't looked into the error yet but I will.

[chinonso098]

Hi there, @james-pre. I was browsing through the repos and took a peek at your 'rewrites' branch, and saw all the refactors you've made to the Terminal Component & the filesystem. Again, you didn't have, but you still went out of your way and did. Thank you very much. I really appreciate it.🙂🙂👍

[chinonso098]

Hi there, @james-pre . I just got around to working on the CheetasOS project after a lengthy pause. I am testing using version 0.16.4 of zenfs/core and 0.2.14 of zenfs/dom.

I blew away the old filesystem index.json file and re-generated it.

I still appear to be having the same issue as last time.

in the Terminal app, the command

cp simple.txt /Desktop ---- this works

cp simple.txt /Documents ----- this fails. Error (core.mjs:7372 ERROR ErrnoError: ENOENT: No such file or directory, '/Documents')

Did you encounter this issue ?

[james-pre]

@chinonso098,

I have been unable to reproduce the bug, which I attribute to the complexity of your project.

If you can create a minimally reproducible example, that would help me a lot.

[chinonso098]

Hi @james-pre

I have created a new repo CheetahOSLite

The only two apps that can be interacted with are File-Explorer and Terminal. Much of the other apps, have been removed.

In file-services and Terminal, I have removed much of the code, peering it down to just what is needed.

Terminal has only 3 functional commands: pwd, ls and cp.

please try these commands in the Terminal app and see if you can replicate the issue.
'cp simple.txt /Desktop'

'cp simple.txt /Documents'

Thanks

[james-pre]

@chinonso098,

This is still too complex to easily debug. If you could create a reproduction of the bug using only Node, without a GUI or anything, that would be ideal. I'll see if I can work with this, but I feel like I won't be able to do very much.

[chinonso098]

@james-pre

I'm not sure how to go about doing that. I unfortunately have no development experience with Node.

The area of focus, is the file.service.ts, the copyFileAsync method. You can even ignore the FileExplorer, because it's copy functionality also call the same method.