[Scala3] Redux: Convert cloneType to an extension method #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes much of the use of this.type in Chisel which is necessary to upgrade to Scala 3.
adkian-sifive
added
API Modification
Scala 3
Can you explain more about why we need this? I know we saw errors related to it, but is there documentation or even a thread somewhere in Scala 3 development explaining the change? |
|
@jackkoenig updated the comment above with some more info |
mwachs5
reviewed
Oct 16, 2024
| @@ -558,7 +556,7 @@ private[chisel3] trait AsyncResetImpl extends Element { self: AsyncReset => | |||
|
|
|||
| override def toString: String = stringAccessor("AsyncReset") | |||
|
|
|||
| def cloneType: this.type = AsyncReset().asInstanceOf[this.type] | |||
| override def _cloneType: Data = AsyncReset() | |||
There was a problem hiding this comment.
Suggested change
| override def _cloneType: Data = AsyncReset() | |
| override def _cloneType: AsyncReset = AsyncReset() |
? perhaps? Why is this one different than the others
mwachs5
reviewed
Oct 16, 2024
| @@ -13,7 +13,7 @@ private[chisel3] trait ClockImpl extends Element { | |||
|
|
|||
| override def toString: String = stringAccessor("Clock") | |||
|
|
|||
| def cloneType: this.type = Clock().asInstanceOf[this.type] | |||
| override def _cloneType: Data = Clock() | |||
mwachs5
reviewed
Oct 16, 2024
|
|
||
| implicit class DataExtensions[T <: Data](self: T) { | ||
|
|
||
| /** Internal API; Chisel users should look at chisel3.chiselTypeOf(...). |
There was a problem hiding this comment.
If this is an internal API, can we make it private to chisel?
mwachs5
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux of #3771. Turns out we need this for Scala3 after all
Ran into errors related to this while adding Scala3 cross-compilation support. Here's a sample of what an error with Dotty looks like:
I suspect this is due to the tightening of the type system in Scala3, specifically changes which make
this.typea more stricter representation of the current instance. I think this SIP might have a more detailed specification of the related changes: https://docs.scala-lang.org/sips/42.type.html#related-scala-issues-resolved-by-the-literal-types-implementationContributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Move cloneType to an extension method in preparation for Scala3
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.