Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to add more org file locations (#42) #55

Merged
merged 1 commit into from
Jun 23, 2024
Merged

feat: Allow to add more org file locations (#42) #55

merged 1 commit into from
Jun 23, 2024

Conversation

seflue
Copy link
Collaborator

@seflue seflue commented Jun 22, 2024

Supporting more then one org file locations allows the user to integrate existing orgmode agenda files into the org-roam knowledge graph.

Implements #42.

@seflue seflue force-pushed the multiple_orgfile_directories branch from 9934a88 to 4e99ab4 Compare June 22, 2024 12:09
@seflue seflue requested a review from chipsenkbeil June 22, 2024 12:11
chipsenkbeil
chipsenkbeil requested changes Jun 22, 2024
View reviewed changes
Copy link
Owner

@chipsenkbeil chipsenkbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall. Left some requests that are nitpicks on grammar and asks for some documentation. Once we get that updated, let's merge this in as another fantastic contribution from your side! 😄

DOCS.org Outdated Show resolved Hide resolved
DOCS.org Outdated Show resolved Hide resolved
DOCS.org Outdated Show resolved Hide resolved
lua/org-roam/database.lua Show resolved Hide resolved
spec/setup_spec.lua Show resolved Hide resolved
@chipsenkbeil
Copy link
Owner

Oh, and I wasn't sure if you were done with the branch from your last PR. Since it seems like you are, we should delete that branch and this one once it's merged.

@seflue seflue force-pushed the multiple_orgfile_directories branch from 4e99ab4 to 4dbfe48 Compare June 22, 2024 23:31
@seflue
feat: Allow to add more org file locations (#42)
a5377b0 
Supporting more then one org file locations allows the user to integrate
existing orgmode agenda files into the org-roam knowledge graph.

Implements #42.
@seflue seflue force-pushed the multiple_orgfile_directories branch from 4dbfe48 to a5377b0 Compare June 22, 2024 23:41
@seflue
Copy link
Collaborator Author

seflue commented Jun 22, 2024 •
edited
Loading

Looks fine overall. Left some requests that are nitpicks on grammar and asks for some documentation. Once we get that updated, let's merge this in as another fantastic contribution from your side! 😄

Thanks for reviewing! I addressed all your comments, fixed the typos and mistakes and added the documentation and comments.

Oh, and I wasn't sure if you were done with the branch from your last PR. Since it seems like you are, we should delete that branch and this one once it's merged.

Yes, we can delete the last branch (which I just did) and also this one as soon as the PR is merged (which I'll do).

@seflue seflue requested a review from chipsenkbeil June 22, 2024 23:44
@chipsenkbeil
Copy link
Owner

Good to go!

@seflue seflue merged commit 01b4666 into main Jun 23, 2024
6 checks passed
@seflue seflue deleted the multiple_orgfile_directories branch June 23, 2024 09:27
@seflue seflue mentioned this pull request Jun 23, 2024
Closed
@chipsenkbeil chipsenkbeil mentioned this pull request Oct 15, 2024
Closed
@seflue seflue mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipsenkbeil chipsenkbeil chipsenkbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seflue @chipsenkbeil