From f2a2a926fd1e5759eb5092b9d5b5011fe9eea9d7 Mon Sep 17 00:00:00 2001 From: Chirayu Krishnappa Date: Thu, 22 Aug 2013 16:31:40 -0700 Subject: [PATCH] revert: fix($sce): allow IE7 standards mode to pass non-quirks mode test This reverts commit 637c9b1611c5a75a42048ee1c591521c7031751a. (ref #3633 and #3646) The minimum bar for $sce is IE8 in standards mode. IE7 standards mode is not supported. If you must support IE7, you should disable $sce completely. angular.module('ie7support', []).config(function($sceProvider) { // Completely disable SCE to support IE7. $sceProvider.enabled(false); }); --- src/ng/sce.js | 2 +- test/ng/sceSpecs.js | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/ng/sce.js b/src/ng/sce.js index 68b97f61c4ef..60356097c9c0 100644 --- a/src/ng/sce.js +++ b/src/ng/sce.js @@ -620,7 +620,7 @@ function $SceProvider() { // the "expression(javascript expression)" syntax which is insecure. if (enabled && msie) { var documentMode = $document[0].documentMode; - if (documentMode !== undefined && documentMode < 7) { + if (documentMode !== undefined && documentMode < 8) { throw $sceMinErr('iequirks', 'Strict Contextual Escaping does not support Internet Explorer version < 9 in quirks ' + 'mode. You can fix this by adding the text to the top of your HTML ' + diff --git a/test/ng/sceSpecs.js b/test/ng/sceSpecs.js index c8a051e869cd..75c1fbaa156b 100644 --- a/test/ng/sceSpecs.js +++ b/test/ng/sceSpecs.js @@ -58,11 +58,7 @@ describe('SCE', function() { } it('should throw an exception when sce is enabled in quirks mode', function() { - runTest(true, 5, true); - }); - - it('should NOT throw an exception when sce is enabled and in IE7 standards mode', function() { - runTest(true, 7, false); + runTest(true, 7, true); }); it('should NOT throw an exception when sce is enabled and in standards mode', function() { @@ -74,10 +70,6 @@ describe('SCE', function() { }); it('should NOT throw an exception when sce is disabled even when in quirks mode', function() { - runTest(false, 5, false); - }); - - it('should NOT throw an exception when sce is disabled and in IE7 standards mode', function() { runTest(false, 7, false); });