Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments to load libary directly #29

Open
manpen opened this issue Oct 11, 2019 · 1 comment
Open

Minor adjustments to load libary directly #29

manpen opened this issue Oct 11, 2019 · 1 comment

Comments

@manpen
Copy link
Collaborator

manpen commented Oct 11, 2019

In the still pending PR for NetworKit I decided to copy the code to modify it slightly. However, actually not many changes are necessary:

1.) I need to be able to pass a PRNG reference rather than a seed
2.) I need to be able to stop the generation prematurely (NetworKit stops algorithms on SIGINT)

The first one is easy: I could add a SpatialTree::generateEdges(std::mt19937_64&); overload.
Additionally I would like to provide std::vector<std::mt19946_64*> overloads to generateWeights and generatePositions.

For the second I would add a template <typename StopCallback> to the SpatialTree which would default top a "never-stop" predicate and hence should be removed by the compiler if it remains unused.

Would you accept such a PR? Then we could use the library directly as a git submodule.

@chistopher
Copy link
Owner

1.) Fine with me
2.) A bit ugly, but I have no better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants